Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): reorgs in starknet_subscribeNewHeads #2249

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

sistemd
Copy link
Contributor

@sistemd sistemd commented Sep 18, 2024

Finally closes #2214. Streams reorg events from starknet_subscribeNewHeads as mandated by the 0.8 spec.

@sistemd sistemd requested a review from a team as a code owner September 18, 2024 14:17
@sistemd sistemd force-pushed the sistemd/starknet-subscribe-new-heads-reorgs branch from 7a62974 to 527cc78 Compare September 18, 2024 14:27
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sistemd sistemd force-pushed the sistemd/starknet-subscribe-new-heads-reorgs branch from 882e7d9 to 775a949 Compare September 20, 2024 10:06
@sistemd sistemd merged commit f4fcad9 into main Sep 20, 2024
7 checks passed
@sistemd sistemd deleted the sistemd/starknet-subscribe-new-heads-reorgs branch September 20, 2024 10:11
sistemd added a commit that referenced this pull request Sep 22, 2024
…eads-reorgs

feat(rpc): reorgs in `starknet_subscribeNewHeads`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starknet_subscribeNewHeads
2 participants